Skip to content

Conversation

@jasonkuster
Copy link
Contributor

This change fixes protovalidate compatibility with bazel 9, which requires explicitly loading rules. Note that this does not change behavior when not using bazel 9, as the rule from cc_proto_library simply passes through to native.cc_proto_library (see implementation).

Also fix minor warning about setting a sha256 for the buf toolchain.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2025

CLA assistant check
All committers have signed the CLA.

@jasonkuster
Copy link
Contributor Author

@srikrsna-buf I see you've reviewed prior PRs in this repo, mind taking a look at this very minor nit fix?

@rodaine rodaine changed the title fix: bazel9-compat: explicitly load cc_proto_library Fix bazel9 compatibility by explicitly loading cc_proto_library Dec 15, 2025
@rodaine
Copy link
Member

rodaine commented Dec 15, 2025

Thanks for the patch, @jasonkuster! Looks like there's a lockfile that needs updating. make generate should do the trick.

@jasonkuster
Copy link
Contributor Author

Fixed! Sorry for missing that :)

Copy link
Member

@srikrsna-buf srikrsna-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the lockfile update otherwise looks good

@jasonkuster
Copy link
Contributor Author

huh, my most recent commit does update the lockfile (I ran make generate and it produced a diff which I committed 🤔 ) Do you know if it's possible to get the lockfile diff from CI?

@jasonkuster
Copy link
Contributor Author

Tried again and got a diff 🤷 so we can try CI again?

Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did the trick. Thanks again!

@rodaine rodaine merged commit 087f587 into bufbuild:main Dec 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants