-
Notifications
You must be signed in to change notification settings - Fork 56
Fix bazel9 compatibility by explicitly loading cc_proto_library #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@srikrsna-buf I see you've reviewed prior PRs in this repo, mind taking a look at this very minor nit fix? |
|
Thanks for the patch, @jasonkuster! Looks like there's a lockfile that needs updating. |
|
Fixed! Sorry for missing that :) |
srikrsna-buf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs the lockfile update otherwise looks good
|
huh, my most recent commit does update the lockfile (I ran make generate and it produced a diff which I committed 🤔 ) Do you know if it's possible to get the lockfile diff from CI? |
|
Tried again and got a diff 🤷 so we can try CI again? |
rodaine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did the trick. Thanks again!
This change fixes protovalidate compatibility with bazel 9, which requires explicitly loading rules. Note that this does not change behavior when not using bazel 9, as the rule from cc_proto_library simply passes through to
native.cc_proto_library(see implementation).Also fix minor warning about setting a sha256 for the buf toolchain.