run.ps1 to support Windows OS#42
Open
jithinnetticadan wants to merge 19 commits into
Open
Conversation
Collaborator
|
Hi @jithinnetticadan can you please update the README/Wiki for this with some images so that we can understand usage of ps1 script as well? |
Author
|
Sure, working on it. |
jithinnetticadan
left a comment
jithinnetticadan
left a comment
Author
There was a problem hiding this comment.
Submitting for review the files that needs to be modified to support windows installation as well as the run.ps1 & Readme-Windows file
Screenshots:
Author
There was a problem hiding this comment.
@Hackerbone
Updated Readme.md
All DockerFiles running scripts should also have && sed -i 's/\r$//' /entrypoint.sh to address the CRLF issue
Sample: RUN chmod +x /entrypoint.sh && sed -i 's/\r$//' /entrypoint.sh
Author
There was a problem hiding this comment.
@Hackerbone Updated the user.controller.ts, vnc.controller.ts and run.sh files to address the noVNC issue.
Fixes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Execution file to setup the tool in Windows.