replace master/slave naming convention with coordinator/worker#650
replace master/slave naming convention with coordinator/worker#650mhat wants to merge 4 commits intoburke:masterfrom
Conversation
README.md
Outdated
|
|
||
| [](https://gitter.im/zeus-application-preloader/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | ||
| [](https://travis-ci.org/burke/zeus) | ||
| [](https://travis-ci.org/burke/zeus) |
| return coordinator_socket if coordinator_socket | ||
|
|
||
| fd = ENV['ZEUS_MASTER_FD'].to_i | ||
| self.master_socket = UNIXSocket.for_fd(fd) |
There was a problem hiding this comment.
typo on this line (closing paren shouldn't be in the right square bracket)
There was a problem hiding this comment.
Meh, I had fixed this locally to get tests passing but failed to commit. My bad!
|
now: I don't know why test are failing, but FWIW I'm a fan of this change, however difficult it's going to make merging with any open branches. |
sideshowcoder
left a comment
sideshowcoder
left a comment
There was a problem hiding this comment.
I think the tests are failing due to MacOS oddities I have seen this before and they might be flaky on OSX so I restarted them just to see (probably not something to fix in this PR). In general I'm in favor of this but as it is a massive change and hard to review and I'm currently not using zeus anymore I don't feel comfortable merging it.
| #[](http://travis-ci.org/qrush/m) | ||
| # | ||
| # | ||
| # |
There was a problem hiding this comment.
I think the find and replace went to far here as this is not part of this repo.
3 participants
Description of Problem
Typical story: team loves software, situation comes up where team learns their favorite software happens to use antiquated terminology, ... so an attempt to improve that. Hoping it'll be more like the Mozilla/Django story than Redis.
Observed Behavior
Expected Behavior