helm: fix serviceAccountName and extraVolumes

[medarion]

#924 introduced some regressions in the Helm chart:

• the serviceAccountName helper was broken; surfaced when supplying .Values.serviceAccount.create as false
• the deployment did not render when .Values.extraVolumes was provided

This PR fixes the Helm chart and also makes the behaviour of the service account creation reflect what the docs state: previously it would always create the sql-exporter service account. Now it will use the name as specificed in the Helm release.

I'm aware this changes current behaviour, but considering that until now supplying serviceAccount.create=true together with serviceAccount.name did not have any effect, I would consider that a bug fix, rather than a breaking change 🤔

[burningalchemist]

Hey @medarion, thanks for reporting the issue. I assume it's #924 (#933 doesn't contain any helm changes at all). 👍

[burningalchemist]

@medarion Could you please bump up the version in Chart.yaml to 0.16.1 and run make gen_docs after?

[medarion]

Hey @medarion, thanks for reporting the issue. I assume it's #924 (#933 doesn't contain any helm changes at all). 👍

Yes, of course, I changed the description.

@medarion Could you please bump up the version in Chart.yaml to 0.16.1 and run make gen_docs after?

I did, but I had to run it without the --sort-values-order file option. Otherwise the Readme changes much more than intended.

[burningalchemist]

@medarion thanks for the fix! 🚀
@zofer1zohargo you might want to check it out as it might affect your workloads possibly 👍

[zofer1zohargo]

Yes, my PR fixed the service account issue. I believe this is the same fix, which I assume is similar to the extraVolume issue. I will check for conflicting changes. Thank you