Fixed bingo get fails on Windows #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
requested changes
Jan 24, 2025
Owner
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks so much for helping!
I gave some suggestions on a bit cleaner approach, but good progress and thanks for approaching this! 💪🏽
Contributor
Author
@bwplotka Thanks for the suggestions! I've already made the changes, please take a look and let me know if there's anything else need to improve! 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make sure opened files are closed immediately (instead of at defer) if we don't need it anymore.
On Windows an error occurs when we try to rename from/to an opened files. Calling
os.Rename(old, new)we should make sure to close botholdandnewfiles (ifnewis existed and opened).Fixes #127