fix(variables): always build for GOHOSTOS #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Nov 5, 2025
Owner
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Brilliant idea and well executed. Thanks!
Owner
|
We might need to fix our tests at this point - we depend on benchstat latest (just any dep to use) and they broke compat with old Go versions. I explained some ideas how: #162 but won't have time to do this this week (I can help in reviewing!) |
Signed-off-by: Ben Dronen <dronenb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
promu crossbuild, sincebingois used to manage/build dependencies on the fly within the crossbuild container, which has build target GOOS, GOARCH, GOARM, etc. set, the tool which performs this build (promu) gets built by the Makefile generated bybingo, which can causepromuto not be executable properly within the container, since it gets built with its intended target's GOOS, GOARCH, and GOARM. This change will forcebingoto always build the tool for the host architecture.See:
darwin/arm64thanos-io/thanos#6824 (comment)