fix: removing hardcoded traceflag#53
Merged
Merged
Conversation
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
calebschoepp
approved these changes
Apr 30, 2026
Contributor
calebschoepp
left a comment
calebschoepp
left a comment
There was a problem hiding this comment.
Mind adding detail to the description for posterities sake?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had configured our host to sample traces, and we were getting random component traces that were detached from the larger host trace. This fix ensures that the exported component traces matches the context that the host provides.
Also, the exemplars conversion logic was flat out wrong. The tracing portion uses hex strings, and this was just raw converting bytes to string.