Skip to content

feat: make go sdk accessible via go get#54

Merged
asteurer merged 2 commits into
bytecodealliance:mainfrom
asteurer:go-updates
May 19, 2026
Merged

feat: make go sdk accessible via go get#54
asteurer merged 2 commits into
bytecodealliance:mainfrom
asteurer:go-updates

Conversation

@asteurer
Copy link
Copy Markdown
Contributor

@asteurer asteurer commented May 2, 2026

Users should now be able to run go get to retrieve the Go SDK.

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@asteurer asteurer requested a review from calebschoepp May 2, 2026 17:45
Copy link
Copy Markdown
Contributor

@calebschoepp calebschoepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I really understand why this enables go get. Is it just because the paths were incorrect before?

Comment thread go/examples/spin-basic/go.mod Outdated
Comment thread go/README.md
@asteurer
Copy link
Copy Markdown
Contributor Author

I'm not sure I really understand why this enables go get. Is it just because the paths were incorrect before?

go get requires a go.mod file at the root of the repository (which wasn't there before). It's also not smart enough to know that there's a Go package in the /go directory, so users will have to specify when they import it.

@calebschoepp
Copy link
Copy Markdown
Contributor

go get requires a go.mod file at the root of the repository (which wasn't there before). It's also not smart enough to know that there's a Go package in the /go directory, so users will have to specify when they import it.

What does the go get command look like for the user? Maybe this is a start for the motivation we needed to split repos if this is too painful and awkward.

@asteurer
Copy link
Copy Markdown
Contributor Author

Unless I'm mistaken, the go get command will be go get github.com/bytecodealliance/opentelemetry-wasi

@calebschoepp
Copy link
Copy Markdown
Contributor

Unless I'm mistaken, the go get command will be go get github.com/bytecodealliance/opentelemetry-wasi

Oh nvm then. I misunderstood you

@calebschoepp
Copy link
Copy Markdown
Contributor

Let me know when you want another round of reviews on this.

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@asteurer asteurer requested a review from calebschoepp May 17, 2026 21:55
@asteurer
Copy link
Copy Markdown
Contributor Author

Thanks for your patience! Ready for another pass when you have a moment.

Copy link
Copy Markdown
Contributor

@calebschoepp calebschoepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! Ready for another pass when you have a moment.

Haha no, thank you for your patience. I'm definitely the slower part of this equation.

@asteurer asteurer merged commit 2962a28 into bytecodealliance:main May 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants