Update examples to 1.4.0#26
Merged
diarmidmackenzie merged 11 commits intoJan 5, 2023
Merged
Conversation
Patch no longer needed.
This reverts commit 23f6256.
vincentfretin
requested changes
Jan 5, 2023
Member
vincentfretin
left a comment
There was a problem hiding this comment.
Changes looks good, I added some comments. I just reviewed the changes in this PR, I didn't test the examples myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all examples to A-Frame 1.4.0, and fixes various issues arising:
Of the issues found upgrading to 1.4.0, the ones that aren't fixed are:
The branch that includes this PR is temporarily published at:
https://diarmidmackenzie.github.io/aframe-physics-system/examples/