Skip to content

refactor(gcp): harden compute engine request validation#83

Open
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
shivv23:fix-gcp-compute-safe-validation
Open

refactor(gcp): harden compute engine request validation#83
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
shivv23:fix-gcp-compute-safe-validation

Conversation

@shivv23
Copy link

@shivv23 shivv23 commented Mar 14, 2026

Summary

  • add typed GcpApiError for validation/auth/http/serialization failures
  • introduce gcp::middleware helpers for required field extraction and authorized JSON request execution
  • refactor gcp_compute_engine to remove panic-prone unwrap paths and centralize request execution
  • add unit tests for validation and payload parsing paths

Testing

  • cargo test build_create_node_payload -- --nocapture (blocked by pre-existing unrelated compile errors in current main branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant