🎨 Palette: Make category rows fully clickable and accessible#102
🎨 Palette: Make category rows fully clickable and accessible#102
Conversation
Wrapped the CategoryRow contents in a Button to expand the hit target to the entire row, rather than just the small checkbox. Added accessibility modifiers to combine the children for VoiceOver and properly announce the selection state. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Wrapped the
CategoryRowHStackcontents in aButtonand added accessibility modifiers.🎯 Why: Previously, only the small checkbox icon was clickable. This expands the hit area to the entire row, making it much easier to select categories. Additionally, it groups the elements for screen readers and announces the selection state properly.
📸 Before/After: N/A (Functional/Accessibility change).
♿ Accessibility: Added
.accessibilityElement(children: .combine)to group the row into a single actionable unit, and.accessibilityAddTraits(result.isSelected ? [.isSelected] : [])to announce the selection state.PR created automatically by Jules for task 16189622027175880575 started by @acebytes