Conversation
Migrates away from using `shell("/usr/bin/which \(tool)")` via
`/bin/bash -c` which passes parameters via string interpolation.
Instead, it now directly executes `/usr/bin/which` using `Process()`
with the tool safely supplied via `process.arguments = [tool]`.
This eliminates a command injection risk as a defense-in-depth measure.
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
toolExistsfunction relies on executing/usr/bin/whichvia a shell wrapper (shell("/usr/bin/which \(tool)")), which interpolates strings directly into bash. While inputs are currently hardcoded, this represents a command injection risk if dynamic tools are checked in the future.Process()execution. Fixed the potential blocking issue by reading the pipe buffer beforewaitUntilExit()./usr/bin/whichwithProcess.PR created automatically by Jules for task 9604598447133785738 started by @acebytes