⚡ Bolt: Optimize ObservableObject published array updates#106
⚡ Bolt: Optimize ObservableObject published array updates#106
Conversation
Refactored `@Published` array mutations in `CacheoutViewModel` to use `.map` instead of `for` loops. Modifying a `@Published` array in a loop triggers multiple `objectWillChange` notifications (one per iteration), causing unnecessary SwiftUI view re-renders. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
@Publishedarray mutations inCacheoutViewModelto use.mapinstead offorloops. Added code comments explaining the optimization.🎯 Why: Modifying a
@Publishedarray in a loop triggers multipleobjectWillChangenotifications (one per iteration), causing unnecessary SwiftUI view re-renders.📊 Impact: Reduces UI re-renders and main thread blocking during "Select All", "Select Safe", and "Deselect All" actions. Operations go from O(N) re-renders to O(1) re-renders.
🔬 Measurement: Verify that selecting and deselecting large lists of node_modules feels significantly more responsive and uses less CPU during the operation.
PR created automatically by Jules for task 9970229631223783095 started by @acebytes