Skip to content

🎨 Palette: Improve list row accessibility and hit targets#109

Open
acebytes wants to merge 1 commit intomainfrom
palette/clickable-rows-14313494041965054711
Open

🎨 Palette: Improve list row accessibility and hit targets#109
acebytes wants to merge 1 commit intomainfrom
palette/clickable-rows-14313494041965054711

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Wrapped list rows in Button with contentShape, and combined accessibility elements.
🎯 Why: Checkbox-only buttons create poor hit targets and VoiceOver reads row contents fragmentally.
📸 Before/After: Rows are now fully clickable and highlighted correctly.
♻️ Accessibility: Added .accessibilityElement(children: .combine) and .isSelected trait for VoiceOver users.


PR created automatically by Jules for task 14313494041965054711 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant