Skip to content

⚡ Bolt: Optimize view model collection updates#111

Open
acebytes wants to merge 1 commit intomainfrom
bolt-optimize-viewmodel-updates-5025282328415269806
Open

⚡ Bolt: Optimize view model collection updates#111
acebytes wants to merge 1 commit intomainfrom
bolt-optimize-viewmodel-updates-5025282328415269806

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Replaced for loops that mutate individual elements of @Published arrays (scanResults, nodeModulesItems) with .map functions in CacheoutViewModel.swift. Also added explicit comments explaining the optimization.

🎯 Why: Mutating an element of a @Published array in-place triggers objectWillChange and a corresponding UI view re-render for every single iteration of the loop. This can cause severe stuttering when selecting or deselecting many cache items at once.

📊 Impact: Reduces property change notifications from O(N) to O(1) per function call. The UI will now recalculate exactly once per bulk selection/deselection action.

🔬 Measurement: Select "Smart Clean" or select/deselect all node_modules items with many projects loaded. The UI will respond instantly without queuing up N separate render passes.


PR created automatically by Jules for task 5025282328415269806 started by @acebytes

Replacing loops over `@Published` arrays with mapped re-assignments in `CacheoutViewModel`. This prevents O(N) UI update notifications and batches them into a single O(1) notification.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant