Skip to content

🎨 Palette: Make list rows fully clickable#116

Open
acebytes wants to merge 1 commit intomainfrom
palette/clickable-list-rows-17049268922123026680
Open

🎨 Palette: Make list rows fully clickable#116
acebytes wants to merge 1 commit intomainfrom
palette/clickable-list-rows-17049268922123026680

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Wrapped the entire HStack in CategoryRow and NodeModulesRow in a Button to increase the hit area.

🎯 Why: Clicking just the small circle checkbox is difficult. Making the whole row clickable is more intuitive, increases the hit target, and provides a significantly better VoiceOver experience by combining the row elements into a single cohesive action.

📸 Before/After: Visuals remain unchanged (the layout and styling are preserved via .buttonStyle(.plain)), but the hit target is now the full width of the row instead of just the checkbox.

♿ Accessibility:

  • Combined all row children into a single accessibility element using .accessibilityElement(children: .combine).
  • Added the .isSelected trait dynamically when checked via .accessibilityAddTraits(isSelected ? [.isSelected] : []).

PR created automatically by Jules for task 17049268922123026680 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant