Prevent infinite loops from zero-interval DatePeriods#499
Open
dereuromark wants to merge 1 commit into3.xfrom
Open
Prevent infinite loops from zero-interval DatePeriods#499dereuromark wants to merge 1 commit into3.xfrom
dereuromark wants to merge 1 commit into3.xfrom
Conversation
Adds validation to ChronosPeriod and ChronosDatePeriod constructors to throw an InvalidArgumentException when given a DatePeriod with a zero interval (e.g., PT0S or P0D). Without this check, iterating over such a period causes an infinite loop that can crash the server. Also fixes typo in ChronosDatePeriodTest (ChronosDAte -> ChronosDate).
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChronosPeriodandChronosDatePeriodconstructors to throwInvalidArgumentExceptionwhen given aDatePeriodwith a zero intervalThe Problem
Creating a
ChronosPeriodwith a zero interval causes an infinite loop:The Fix
The constructor now validates the interval and throws an exception:
Related
Similar issue was reported for Carbon: briannesbitt/Carbon#3259