Cascade Deletes#70
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 91.42% 92.29% +0.87%
==========================================
Files 15 15
Lines 618 662 +44
Branches 42 44 +2
==========================================
+ Hits 565 611 +46
+ Misses 47 46 -1
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
calebsyring
force-pushed
the
66-cascade-deletes
branch
from
e316f17 to
7e333a1
Compare
JohnBrennan95
left a comment
JohnBrennan95
left a comment
There was a problem hiding this comment.
Just saw the single page issue. Not sure if this will be a major concern.
| ] | ||
|
|
||
| @classmethod | ||
| def get_due_since(cls, timestamp: datetime) -> list[UptimeMonitorModel]: |
There was a problem hiding this comment.
After looking into this a bit, it appears that DDB will only return 1 MB of data on a response, which could lead to loss of information. If there are multiple pages of data, we will need to use a 'LastEvaluatedKey' provided by DDB if it needs to create a next page for the query. Idk how much data we are expecting to be returned, so this may not be a major issue. We could probably loop over it I would imagine.
There was a problem hiding this comment.
Good call. I'm going to create a separate issue for this since the problem spans more than this PR.
2 participants
fixes #66