Skip to content

Alert Integrations#71

Merged
calebsyring merged 3 commits into
masterfrom
alert-integrations
Mar 3, 2026
Merged

Alert Integrations#71
calebsyring merged 3 commits into
masterfrom
alert-integrations

Conversation

@JohnBrennan95
Copy link
Copy Markdown
Collaborator

Created the core functionality for the alerting integrations. Unit tests passing, functioning as intended. Once we get an actual target for the email and slack notifications, in theory we can test in an actual env. Will need valid credentials for slack and whatever email will be used. I suggest we use a dedicated slack channel / email in the event that we create lots of spam while testing.

@JohnBrennan95 JohnBrennan95 self-assigned this Feb 19, 2026
@JohnBrennan95 JohnBrennan95 added the enhancement New feature or request label Feb 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 75.97403% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.17%. Comparing base (e54cb68) to head (95c62f4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/critic/libs/mailgun.py 27.77% 13 Missing ⚠️
src/critic/alerts.py 72.72% 10 Missing and 2 partials ⚠️
src/critic/libs/slack.py 33.33% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   91.67%   89.17%   -2.51%     
==========================================
  Files          17       21       +4     
  Lines         829      979     +150     
  Branches       60       73      +13     
==========================================
+ Hits          760      873     +113     
- Misses         57       92      +35     
- Partials       12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@calebsyring calebsyring merged commit e184398 into master Mar 3, 2026
3 checks passed
@calebsyring calebsyring deleted the alert-integrations branch March 3, 2026 15:54
@calebsyring calebsyring mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants