Skip to content

Enforce log limit per monitor#76

Merged
JohnBrennan95 merged 1 commit into
masterfrom
enforce-log-limit
Apr 30, 2026
Merged

Enforce log limit per monitor#76
JohnBrennan95 merged 1 commit into
masterfrom
enforce-log-limit

Conversation

@calebsyring
Copy link
Copy Markdown
Owner

fixes #65

@calebsyring calebsyring self-assigned this Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (e184398) to head (4dc194d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   89.17%   89.43%   +0.25%     
==========================================
  Files          21       21              
  Lines         979     1003      +24     
  Branches       73       76       +3     
==========================================
+ Hits          873      897      +24     
  Misses         92       92              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@JohnBrennan95 JohnBrennan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not requesting changes, just trying to get a second pair of eyes on my below comment. If we decide this is okay behavior, I am good to sign off on this.

Comment thread src/critic/libs/uptime.py
@JohnBrennan95 JohnBrennan95 added the enhancement New feature or request label Apr 10, 2026
@tgubler9
Copy link
Copy Markdown
Collaborator

Not requesting changes, just trying to get a second pair of eyes on my below comment. If we decide this is okay behavior, I am good to sign off on this.

I'll look at it tonight

Copy link
Copy Markdown
Collaborator

@tgubler9 tgubler9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only had 2 comments. Very small details. Feel free to disagree if company needs dont align

Comment thread src/critic/libs/uptime.py
Comment thread uv.lock
[[package]]
name = "joserfc"
version = "1.6.1"
version = "1.6.3"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a nitpick, could you explain why you are updating these? Nothing specific needed, just something like "updated packages because of CVE" or "newer version wanted"

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just to get the safety checks in CI passing. Resolving.

Copy link
Copy Markdown
Collaborator

@JohnBrennan95 JohnBrennan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Caleb!

@JohnBrennan95 JohnBrennan95 merged commit b9811b8 into master Apr 30, 2026
5 checks passed
@JohnBrennan95 JohnBrennan95 deleted the enforce-log-limit branch April 30, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit Monitor Log Storage

3 participants