Enforce log limit per monitor#76
Conversation
c4e42fd to
f4d4470
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 89.17% 89.43% +0.25%
==========================================
Files 21 21
Lines 979 1003 +24
Branches 73 76 +3
==========================================
+ Hits 873 897 +24
Misses 92 92
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f4d4470 to
4dc194d
Compare
JohnBrennan95
left a comment
There was a problem hiding this comment.
Not requesting changes, just trying to get a second pair of eyes on my below comment. If we decide this is okay behavior, I am good to sign off on this.
I'll look at it tonight |
tgubler9
left a comment
There was a problem hiding this comment.
Looks good, only had 2 comments. Very small details. Feel free to disagree if company needs dont align
| [[package]] | ||
| name = "joserfc" | ||
| version = "1.6.1" | ||
| version = "1.6.3" |
There was a problem hiding this comment.
Also a nitpick, could you explain why you are updating these? Nothing specific needed, just something like "updated packages because of CVE" or "newer version wanted"
There was a problem hiding this comment.
Yeah, just to get the safety checks in CI passing. Resolving.
JohnBrennan95
left a comment
There was a problem hiding this comment.
Looks good, thanks Caleb!
fixes #65