fix: gradle plugin React Native resource linking#169
Merged
Conversation
artus9033
requested review from
andrei-zgirvaci,
hurali97,
krozniata and
thymikee
thymikee
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a fix for the Gradle plugin's
RNSourceSets::configureSourceSets, which had a hardcoded path introduced in feature commit bringing support for RN0.81+to be added to resources to every source set (react/release). In a future commit, the algorithm had a rework, withcreateBundleReleaseJsAndAssetsbeing parametrized to match the given source set (createBundle${capitalizedVariantName}JsAndAssets), butreact/releasehad not been parametrized.Due to this problem, versions of the Gradle plugin >=
0.6.0are affected and cause packaging of release JS artifacts in debug configurations, also having a side effect (guarding against this error!) of Gradle failing due to debug task not having an explicit dependency on the release one (our plugin adds such between tasks within the same configuration, which is correct) - an error like the below:Test plan
CI green + works with a locally published version of the plugin.