Skip to content

refactor: alter Android API for loading the JS bundle from disk #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artus9033 merged 4 commits into from
Jan 19, 2026
Merged

refactor: alter Android API for loading the JS bundle from disk #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49b2c5f
docs: update docs for newest support of local file system bundles int…
artus9033 Jan 19, 2026
cc91366
chore: added changeset
artus9033 Jan 19, 2026
c07598c
refactor: alter the Android API for loading JS bundle from disk to su…
artus9033 Jan 19, 2026
cdffde1
chore: update changeset to bump up the minor component
artus9033 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-parts-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@callstack/react-native-brownfield': minor
---

feat(android): allow bundle file path
3 changes: 2 additions & 1 deletion docs/docs/docs/api-reference/java.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ A function used to initialize a React Native Brownfield singleton. Keep in mind
- `useDeveloperSupport`: `Boolean` - Flag to use dev support.
- `packages`: `List<ReactPackage>` - List of your React Native Native modules.
- `mainModuleName`: `String` - Path to react native entry file (when loading from Metro).
- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`.
- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`
- `bundleFilePath`: `String` - Optional, should start with `file://`, in which case the JS bundle will be loaded from a local file; alternatively, can start with `asset://`, in which case it is equivalent to `bundleAssetPath` passed the value without the `asset://` prefix. This value has precedence over `bundleAssetPath`, if passed.

**Examples:**

Expand Down
3 changes: 2 additions & 1 deletion docs/docs/docs/api-reference/kotlin.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ A function used to initialize a React Native Brownfield singleton. Keep in mind
- `useDeveloperSupport`: `Boolean` - Flag to use dev support.
- `packages`: `List<ReactPackage>` - List of your React Native Native modules.
- `mainModuleName`: `String` - Path to react native entry file (when loading from Metro).
- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`.
- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`
- `bundleFilePath`: `String` - Optional, should start with `file://`, in which case the JS bundle will be loaded from a local file; alternatively, can start with `asset://`, in which case it is equivalent to `bundleAssetPath` passed the value without the `asset://` prefix. This value has precedence over `bundleAssetPath`, if passed.

**Examples:**

Expand Down
7 changes: 2 additions & 5 deletions ...nfield/android/src/main/java/com/callstack/reactnativebrownfield/ReactNativeBrownfield.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,13 @@ class ReactNativeBrownfield private constructor(val reactHost: ReactHost) {
onJSBundleLoaded: OnJSBundleLoaded? = null
) {
val reactHost: ReactHost by lazy {
val bundlePath = options["bundleAssetPath"] as? String ?: "index.android.bundle"
val isFilePath = bundlePath.startsWith("/") || bundlePath.startsWith("file://") || bundlePath.startsWith("assets://")

getDefaultReactHost(
context = application,
packageList = (options["packages"] as? List<*> ?: emptyList<ReactPackage>())
.filterIsInstance<ReactPackage>(),
jsMainModulePath = options["mainModuleName"] as? String ?: "index",
jsBundleAssetPath = bundlePath,
jsBundleFilePath = if (isFilePath) bundlePath else null,
jsBundleAssetPath = options["bundleAssetPath"] as? String ?: "index.android.bundle",
jsBundleFilePath = options["bundleFilePath"] as? String,
useDevSupport = options["useDeveloperSupport"] as? Boolean
?: ReactBuildConfig.DEBUG,
jsRuntimeFactory = null
Expand Down