Fix input/output duplication in file_mapper#1408
Draft
lbeckman314 wants to merge 15 commits intodevelopfrom
Draft
Fix input/output duplication in file_mapper#1408lbeckman314 wants to merge 15 commits intodevelopfrom
file_mapper#1408lbeckman314 wants to merge 15 commits intodevelopfrom
Conversation
…unts without creating orphan resources
Co-authored-by: Pauline Ribeyre <4224001+paulineribeyre@users.noreply.github.com>
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is built off of PR #1407 and should be merged to it!
TODO: How to do so against forks? Just merge to develop afterwards #1407 is merged?
Overview 🌀
This PR is an initial (un-tested!) pass at resolving the following file_mapper error introduced when merging Commit 5b95fa0:
This duplication is only happening if we have both inputs and outputs (regardless of the number).
Steps to Reproduce
To test it, create any TES task with at least one input and output.
Credit 🤝
This issue was first identified and documented by @nss10 and the CTDS team, thank you!