Skip to content

Mirror git-drs CLI to be like LFS#232

Open
matthewpeterkort wants to merge 17 commits intodevelopmentfrom
fix/cli
Open

Mirror git-drs CLI to be like LFS#232
matthewpeterkort wants to merge 17 commits intodevelopmentfrom
fix/cli

Conversation

@matthewpeterkort
Copy link
Copy Markdown
Contributor

@matthewpeterkort matthewpeterkort commented May 6, 2026

addresses a bunch of issues see issues in PR linked.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 709b84ce76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go.mod Outdated
Comment on lines +152 to +154
replace github.com/calypr/data-client => ../data-client

replace github.com/calypr/syfon => ../syfon
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove local path replaces from go.mod

Do not commit replace ... => ../... entries here: these paths only exist on the author's machine, so a normal clone cannot resolve github.com/calypr/data-client/syfon dependencies and go commands fail before tests or builds run. Keep these overrides in a local go.work or uncommitted dev-only config instead of repository go.mod.

Useful? React with 👍 / 👎.

Comment thread cmd/lsfiles/main.go Outdated
Comment on lines +34 to +35
if len(branches) == 0 {
return lfs.GetWorktreeLfsFiles(logger)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include hydrated LFS files in ls-files inventory

The default inventory path now calls GetWorktreeLfsFiles when branches is empty, but that function only returns files whose current worktree content is still an LFS pointer. After pull hydrates files, those tracked LFS files disappear from ls-files output, so status */localized reporting and DRS checks miss real tracked files.

Useful? React with 👍 / 👎.

@matthewpeterkort matthewpeterkort requested a review from bwalsh May 6, 2026 23:10
@matthewpeterkort
Copy link
Copy Markdown
Contributor Author

TODO: address #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant