Skip to content

fix: sync sample API templates with Commonalities #606#77

Merged
hdamker-bot merged 2 commits intocamaraproject:mainfrom
hdamker:fix/update-sample-yamls
Apr 12, 2026
Merged

fix: sync sample API templates with Commonalities #606#77
hdamker-bot merged 2 commits intocamaraproject:mainfrom
hdamker:fix/update-sample-yamls

Conversation

@hdamker
Copy link
Copy Markdown
Contributor

@hdamker hdamker commented Apr 12, 2026

What type of PR is this?

Fix.

What this PR does

Syncs sample-service.yaml and sample-service-subscriptions.yaml with the current Commonalities template source (PR #606 branch). Key changes:

  • sample-service-subscriptions.yaml: replaces unreplaced <apiName> placeholders with proper Sample Service names (fixes S-021 tag name validation warning), updates operationIds and security scopes
  • sample-service.yaml: restores template externalDocs URL

sample-implicit-events.yaml was already identical (copied from Commonalities in PR #71).

Related issues

Fixes S-021 validation warning found during r1.1 snapshot review.

Update sample-service.yaml and sample-service-subscriptions.yaml to
match the current Commonalities template source (PR #606 branch).
Fixes placeholder tag names and operationIds that were not replaced
in the previous copy.
@hdamker hdamker requested a review from hdamker-bot as a code owner April 12, 2026 10:40
@hdamker hdamker closed this Apr 12, 2026
@hdamker hdamker reopened this Apr 12, 2026
Replace template placeholder URLs (apiRepository, {apiRepository}) with
the actual repository URL. Fixes S-209 validation error on sample-service.yaml.
@hdamker hdamker closed this Apr 12, 2026
@hdamker hdamker reopened this Apr 12, 2026
@hdamker hdamker closed this Apr 12, 2026
@hdamker hdamker reopened this Apr 12, 2026
@hdamker-bot hdamker-bot merged commit 807b68d into camaraproject:main Apr 12, 2026
4 checks passed
@hdamker hdamker deleted the fix/update-sample-yamls branch April 13, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants