fix(release): generate signed Homebrew frameworks#34
Conversation
Update the Homebrew formula generator so future releases re-sign installed framework bundles instead of individual files. This matches the formula fix that was validated against a clean Homebrew install and real simulator interaction, and prevents future releases from regenerating the broken post_install signing logic. Co-Authored-By: Codex <noreply@openai.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the post_install function in scripts/generate-homebrew-formula.sh to change the signing approach for frameworks and binaries. The previous implementation iterated through files in libexec, performed file type checks using the file command, maintained a signed_paths cache, and avoided signing framework binaries within nested paths. The new implementation replaces this logic with two explicit signing commands targeting frameworks at libexec/Frameworks/*.framework and the binary at libexec/axe. Per-file iteration, file command invocations, and Mach-O qualification checks have been removed. The net change comprises 4 lines added and 15 lines removed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Verification
Note
Medium Risk
Changes the generated Homebrew formula
post_installcodesigning behavior, which can affect end-user installation/runtime on macOS. Scope is small but errors here would break the Homebrew-installed binary and embedded frameworks.Overview
Updates
scripts/generate-homebrew-formula.shso the generated formulapost_installexplicitly re-signs eachFrameworks/*.frameworkbundle, instead of attempting to recursively detect and sign Mach-O files.Also adds an explicit codesign step for the installed
axebinary after frameworks are signed, to keep regenerated formulas aligned with the tap’s signing fix.Written by Cursor Bugbot for commit aa26b10. This will update automatically on new commits. Configure here.