Fix dream mirage#393
Merged
Merged
Conversation
Willenbrink
commented
May 18, 2025
Collaborator
|
How do h1 and httpun relate to each other? |
Contributor
The question was asked in robur-coop/ocaml-h1#12 and anmonteiro/httpun#153 -- while AFAICT h1 supports websockets as well (in contrast to the reply in httpun issue). |
Willenbrink
force-pushed
the
fix-dream-mirage
branch
from
de1302c to
2e74b3d
Compare
Willenbrink
commented
Sep 5, 2025
Willenbrink
force-pushed
the
fix-dream-mirage
branch
3 times, most recently
from
1522ef4 to
e205042
Compare
Willenbrink
force-pushed
the
fix-dream-mirage
branch
from
e205042 to
b748d1f
Compare
minor opam fixes, get rid of mirage-clock Enable test workflow remove psq in the test as well Update pipeline
Willenbrink
force-pushed
the
fix-dream-mirage
branch
from
b748d1f to
faf8ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
dream-miragepackage so that it works with the latest version of Mirage.This required replacing the vendored libraries by the upstream versions and replacing httpaf with h1. In theory httpun could also be used.
This is a bit unfortunate as dream itself uses Httpun currently and dream-mirage h1. I think we should switch dream to h1 as it seems to be more actively supported but that would be too big a change for this PR.