Fix quickstart.sh workflow#418
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the quickstart.sh workflow by changing how we determine a success.
Previously, the
tailcommand would run forever and mess with the exit code.Now, we look for the first 'Ctrl+C' in the output as indicator that the example successfully started and then terminate the background
tail. We await the termination of thattailbefore checking the success file.MacOS fails to run the example for some reason but doesn't show any errors. Not sure whats going on here: https://github.com/camlworks/dream/actions/runs/22228612257/job/64301822852?pr=418. I've disabled quicktest for Mac for now.