[dispatcher] Use more efficient iteration in matching-primary-pairs#154
Merged
camsaul merged 1 commit intocamsaul:masterfrom May 8, 2025
Merged
[dispatcher] Use more efficient iteration in matching-primary-pairs#154camsaul merged 1 commit intocamsaul:masterfrom
camsaul merged 1 commit intocamsaul:masterfrom
Conversation
camsaul
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same reasoning as #152 – non-cached dispatcher still matters; and a reduce-kv is more optimized for iterating maps than a generic
for. I'm deliberately not using transients to accumulate because I assume that absolute most matching method lists will be tiny (a few elements), and the overhead of transients outweighs regular vectors on such small inputs.