Interfaces

[darkleaf]

I replaced definterface+ with definterface for further clojurescript support #20.
UPD: Also I replaced deftype+ with deftype.

Helper functions are not inlined like potemkin do because I not see any performance impact.

So we can do it:

#?(:clj
   (definterface Foo
     (fooBar []))
   :cljs
   (def Foo))

;; helper function
(defn foo-bar [^Foo foo]
  (.fooBar foo))

(deftype Bar []
  #?(:clj Foo
     :cljs Object)
  (fooBar [_] :ok))

(foo-bar (Bar.))

[codecov-io]

Codecov Report

Merging #25 into master will decrease coverage by 0.14%.
The diff coverage is 91.34%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   86.57%   86.43%   -0.15%     
==========================================
  Files          20       20              
  Lines         827      936     +109     
  Branches       48       57       +9     
==========================================
+ Hits          716      809      +93     
- Misses         63       70       +7     
- Partials       48       57       +9

Impacted Files	Coverage Δ
src/methodical/impl/dispatcher/everything.clj	57.69% <0%> (ø)	⬆️
src/methodical/impl/combo/clojure.clj	62.5% <0%> (-37.5%)	⬇️
src/methodical/impl/combo/clos.clj	60% <0%> (ø)	⬆️
src/methodical/impl/combo/threaded.clj	94.11% <0%> (-3.67%)	⬇️
src/methodical/impl/cache/simple.clj	71.42% <100%> (ø)	⬆️
src/methodical/impl/multifn/standard.clj	81.81% <100%> (ø)	⬆️
src/methodical/impl/method_table/clojure.clj	70.58% <100%> (-29.42%)	⬇️
src/methodical/impl/standard.clj	93.75% <100%> (ø)	⬆️
src/methodical/impl/method_table/standard.clj	86.95% <100%> (ø)	⬆️
src/methodical/impl/multifn/cached.clj	86.36% <100%> (ø)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3b737...7ebbd0b. Read the comment docs.

[camsaul]

I want to keep definterface+ and deftype+ for Clojure code since it makes REPL-based development so much nicer by not redefining types/protocols every time the namespace is reloaded.

How about creating some other macro somewhere, e.g. methodical.types/definterface+ that expands to a definterface+ form in :clj and definterface in :cljs? Then it's a simple matter of replacing p.types/definterface+ with m.types/definterface+ where it pops up

[darkleaf]

1. methodical.interface is compiled ahead of time. If you change this namespace you should reload jvm.
2. definterface+ defines helper functions but in clojurescript we also need them.

(definterface+ Foo
  (foo-bar [this]))

;; will be expanded into

;; conditional loading
;; not implemented by me // UPD: implemented
;; https://github.com/ztellman/potemkin/blob/master/src/potemkin/types.clj#L239

;; https://github.com/ztellman/potemkin/blob/master/src/potemkin/types.clj#L251
(definterface Foo
  (foo_bar []))

;; helper function
;; https://github.com/ztellman/potemkin/blob/master/src/potemkin/types.clj#L276
(defn ^:inline ... foo-bar [^Foo foo]
  (.foo_bar foo))

3. ClojureScript not implements interfaces. Look again please:

#?(:clj
   (definterface Foo
     (fooBar []))
   :cljs
   (def Foo)) ;; ### NAME JUST FOR TYPE HINTS ###

;; ### COMMON HELPER FUNCTION ###
(defn foo-bar [^Foo foo]
  (.fooBar foo))

(deftype Bar []
  #?(:clj Foo
     :cljs Object)   ;; ### OBJECT NOT INTERFACE ###
  (fooBar [_] :ok))

(foo-bar (Bar.))

4. For repl development I can add simple macro for clj like definterface+ that not load interface if it already exists.
   https://github.com/ztellman/potemkin/blob/master/src/potemkin/types.clj#L239-L253

[darkleaf]

I implemented defonceinterface for repl dev.
0e65c54

[camsaul]

instead of changing all the interfaces, wouldn't it be easier to change the one or two places where the methods are invoked directly (e.g. StandardMultiFn?)

[darkleaf]

I don't understand what you mean.

I just replaced definterface+ with definterface and replace lisp-case names with camelCase ones.

[camsaul]

Hey @darkleaf, sorry I haven't followed up on this lately. I've been pretty busy shepherding some new releases at work and haven't got a change to circle back to this. Can you show me what running tests for this will look like with ClojureScript? I don't have a ton of ClojureScript experience so I would like to play around with your PR a bit so I can understand it better

[darkleaf]

Can you show me what running tests for this will look like with ClojureScript?

Currently I can't. Because methodical havely used vars and cljs have reduced vars implementation.
We should resolve #29 first.

But I write some cljc code in 7ebbd0b

[camsaul]

I want to get ClojureScript support working in the near future. I'm switching from definterface+ to defprotocol in #71. I'll probably make the switch from deftype+ to plain deftype in the near future as well.