Open
Conversation
Bugfix: Get next token, in unary filters. We found the end of the object. But we forgot to forward the parser to the next token.
Owner
|
Hi @wdichler !!! May I ask for unit tests to validate your pull request ? |
candoumbe
reviewed
Dec 15, 2024
Owner
candoumbe
left a comment
candoumbe
left a comment
There was a problem hiding this comment.
Thanks for submiiting this PR !
Please could you add a test + an issue to describe what this PR will
Author
|
I need some time, i will deliver in the end of the week. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: Get next token, in unary filters. We found the end of the object. But we forgot to forward the parser to the next token.