Addressing PR comments — TypeScript SDK refactor + Chevrotain-based parser

[Copilot]

Addresses all PR review feedback on the TypeScript SDK and replaces the hand-written parser with a Chevrotain-based implementation that mirrors the C# FilterTokenParser behaviour.

Changes Made

TypeScript SDK structure

• Removed the Python SDK entirely (src/python/, both Python workflows, .devcontainer/python/ config, and all related .gitignore / README.md entries)
• Each concrete class and interface now lives in its own camelCase file (e.g. equalsFilter.ts, iFilter.ts)
• Removed the Expression suffix from all IFilter-implementing classes (EqualsFilter, ContainsFilter, StartsWithFilter, etc.)
• Added explicit public / private access modifiers throughout
• Applied single-entry single-exit style to all methods
• Split test files so each class has its own test file with Arrange / Act / Assert sections

Chevrotain parser (src/typescript/src/parser.ts)

• Replaced the hand-written recursive descent parser with a Chevrotain EmbeddedActionsParser
• Lexer: 11 tokens — Escaped, Text, TO (with longer_alt so "TORONTO" is a single token), Comma, Pipe, Bang, Asterisk, LeftSquare, RightSquare, Equals, Whitespace
• Grammar rules mirror the C# parser: filterInput, fieldOrValuePart, fieldAssignment, inheritedValuePart, valueExpression, pipeExpression, negatedExpr, primaryExpr, rangeExpression, valueTextChunks, rangeValueChunks, fieldNameRule
• Pre-processing step URL-decodes input and normalises &-separated multi-field expressions (backslash-escaped \& is treated as a literal ampersand, not a separator)
• Public API is unchanged: import { parse } from "parsers" and parse(input, options?) work identically from the caller's perspective

Jest / build config

• Added chevrotain@^12 as a runtime dependency and esbuild as a dev dependency
• Added jest.global-setup.cjs: uses esbuild to pre-bundle Chevrotain (pure ESM) to CommonJS before tests run, keeping the existing ts-jest CJS setup intact
• Added src/typescript/.jest-cache/ to .gitignore

Testing

• ✅ All 77 tests pass (41 parser tests + 36 filter-class tests)
• ✅ TypeScript build succeeds with no errors
• ✅ ESLint passes with no errors

Original prompt

Objective

Create a monorepo structure to support Python and TypeScript SDKs alongside the existing C# DataFilters library, with completely separate CI/CD pipelines to avoid interfering with the existing C# build process.

Requirements

• Preserve existing C# pipelines: Do NOT rename or modify existing integration.yml and delivery.yml workflows (they are auto-generated by Nuke)
• Add new isolated workflows: Create separate workflows for Python and TypeScript that trigger only when their respective code changes
• Monorepo structure: Organize code in src/python/ and src/typescript/ directories
• Respect branch conventions: Use existing develop (default), main, and release/* branches
• Independent CI/CD: Each language has its own integration and delivery pipelines with proper path triggers

Changes to implement

1. New Directory Structure

src/
├── DataFilters/                        # Existing C#
├── python/
│   ├── datafilters/
│   │   ├── __init__.py
│   │   ├── expressions.py
│   │   ├── parser.py
│   │   ├── builder.py
│   │   └── serializers.py
│   ├── tests/
│   │   ├── __init__.py
│   │   ├── test_expressions.py
│   │   ├── test_parser.py
│   │   └── test_builder.py
│   ├── pyproject.toml
│   ├── setup.py
│   └── requirements-dev.txt
│
└── typescript/
    ├── src/
    │   ├── index.ts
    │   ├── expressions.ts
    │   ├── parser.ts
    │   ├── builder.ts
    │   └── serializers.ts
    ├── test/
    │   ├── expressions.test.ts
    │   ├── parser.test.ts
    │   └── builder.test.ts
    ├── package.json
    ├── tsconfig.json
    ├── jest.config.js
    └── .npmignore

2. New Workflows (in .github/workflows/)

python-integration.yml

• Triggers: Push to develop/feature branches, PR to src/python/**
• Matrix: Python 3.8, 3.9, 3.10, 3.11, 3.12
• Tasks: Install, Lint (flake8), Test (pytest), Coverage (codecov)
• Cache: pip dependencies

python-delivery.yml

• Triggers: Push to main/release/* on src/python/**
• Tasks: Build, Test, Publish to PyPI
• Secret: PYPI_API_TOKEN

typescript-integration.yml

• Triggers: Push to develop/feature branches, PR to src/typescript/**
• Matrix: Node 18, 20, 22
• Tasks: Install, Lint (eslint), Build (TypeScript), Test (jest), Coverage
• Cache: npm dependencies

typescript-delivery.yml

• Triggers: Push to main/release/* on src/typescript/**
• Tasks: Build, Test, Publish to npm
• Secret: NPM_TOKEN

3. Configuration Files

src/python/pyproject.toml

• Package metadata
• Dependencies configuration
• Build system setup

src/python/setup.py

• Legacy setup for compatibility
• Includes package data

src/python/requirements-dev.txt

• Development dependencies

src/typescript/package.json

• Package metadata
• Dependencies and devDependencies
• Build/test scripts

src/typescript/tsconfig.json

• TypeScript compilation options

src/typescript/jest.config.js

• Jest test configuration

4. Updated Files

.gitignore

• Add Python patterns: __pycache__/, *.egg-info/, .pytest_cache/, .coverage, dist/, build/
• Add TypeScript patterns: node_modules/, dist/, coverage/, .eslintcache

README.md

• Add section explaining monorepo structure
• Add development instructions for each language

Technical Details

Workflow Path Triggers

Each workflow uses paths: filter to only run when relevant files change:

• Python workflows: src/python/**, .github/workflows/python-*.yml
• TypeScript workflows: src/typescript/**, .github/workflows/typescript-*.yml
• C# workflows: Unmodified (auto-generated)

CI/CD Behavior

• Modifying only Python code → Python workflow runs, C# and TypeScript skipped
• Modifying only TypeScript code → TypeScript workflow runs, C# and Python skipped
• Multi-language PR → All relevant workflows run in parallel
• PR to main/release/* → Deployment workflows run

Compatibility

• Python SDK follows same filter expression format as C#
• TypeScript SDK follows same filter expression format as C#
• Shared specification in docs

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Quelle serait la meilleure façon de fournir des librairies python, typescript pour générer des filtres compatible avec datafilters ?

Assistant: Je vais explorer le dépôt pour mieux comprendre sa structure et vous donner une recommandation optimale.

Assistant: Maintenant, laissez-moi explorer la structure du projet pour mieux comprendre comment fonctionnent les filtres :

Assistant: Maintenant je comprends bien votre projet. DataFilters est une bibliothèque en C# qui permet de filtrer des données avec une syntaxe semblable à Elasticsearch. Pour fournir des librairies Python et TypeScript compatibles, voici les meilleures approches :

🏗️ Architecture recommandée

1. Option A : Mono-dépôt avec code partagé

Créer un dépôt central contenant :

• Core partagé : Spécification...

This pull request was created from Copilot chat.

[codecov]

Codecov Report

❌ Patch coverage is 95.05814% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.39%. Comparing base (51d209f) to head (d739891).

Files with missing lines	Patch %	Lines
src/typescript/src/parser.ts	96.05%	7 Missing and 3 partials ⚠️
src/typescript/src/builder.ts	89.66%	3 Missing ⚠️
src/typescript/src/containsFilter.ts	80.00%	1 Missing and 1 partial ⚠️
src/typescript/src/oneOfFilter.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #574       +/-   ##
============================================
+ Coverage     5.40%   16.39%   +10.99%     
============================================
  Files           56       72       +16     
  Lines         2463     2807      +344     
  Branches       327      369       +42     
============================================
+ Hits           133      460      +327     
- Misses        2319     2332       +13     
- Partials        11       15        +4     

Flag	Coverage Δ
typescript	95.06% <95.06%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[candoumbe]

@copilot

remove all the python implementation. Only keep the typescript part

[Copilot]

@copilot

remove all the python implementation. Only keep the typescript part

Done in commit 72d65fb. Removed src/python/, both Python workflows (python-integration.yml, python-delivery.yml), the .devcontainer/python/ config, and all related entries in .gitignore and README.md. Only the TypeScript SDK remains.

[candoumbe]

@copilot

in general, use the single entry single exit approach when writing methods.

[Copilot]

@copilot

in general, use the single entry single exit approach when writing methods.

Applied in commit b4d0af8 across all TypeScript source files. Methods that had multiple return statements now use a single result variable assigned in each branch and a single return result at the end — specifically parseRange, parseAndExpression, parse, build, and fromDict.

[candoumbe]

@copilot

all typescript classes that inherit from FilterBuilder should not have Expression suffix.
Also keep all files name camelCase

[Copilot]

@copilot

all typescript classes that inherit from FilterBuilder should not have Expression suffix.
...

Done in commit 77b3b1b:

• AndFilterExpression, OrFilterExpression, NotFilterExpression renamed to AndFilter, OrFilter, NotFilter (compound/combinator classes don't carry the Expression suffix)
• All new TypeScript source files renamed to camelCase: EqualsFilterExpression.ts → equalsFilterExpression.ts, IFilter.ts → iFilter.ts, AndFilter.ts → andFilter.ts, etc.
• All test files likewise renamed to camelCase
• All imports and re-exports updated throughout expressions.ts, parser.ts, builder.ts, serializers.ts, index.ts, and all test files

[candoumbe]

@copilot

• remove Expression suffix from all class names that inherit / extends from IFilter.
• keep file name consistent with the class name it holds (and respect camelCase)

[Copilot]

@copilot

• remove Expression suffix from all class names that inherit / extends from IFilter.
  ...

Done in commit 7dc3920. The Expression suffix has been removed from all IFilter-implementing classes:

• EqualsFilterExpression → EqualsFilter (file: equalsFilter.ts)
• ContainsFilterExpression → ContainsFilter (file: containsFilter.ts)
• StartsWithFilterExpression → StartsWithFilter (file: startsWithFilter.ts)
• EndsWithFilterExpression → EndsWithFilter (file: endsWithFilter.ts)
• GreaterThanFilterExpression → GreaterThanFilter (file: greaterThanFilter.ts)
• GreaterThanOrEqualFilterExpression → GreaterThanOrEqualFilter (file: greaterThanOrEqualFilter.ts)
• LessThanFilterExpression → LessThanFilter (file: lessThanFilter.ts)
• LessThanOrEqualFilterExpression → LessThanOrEqualFilter (file: lessThanOrEqualFilter.ts)

All file names now match their class name in camelCase. All imports, barrel exports, and test files updated. 53/53 tests pass.

[candoumbe]

@claude[agent]
Fix all sonar quality gate issues on this PR

[Claude]

@claude[agent]
Fix all sonar quality gate issues on this PR

Fixed all identified SonarCloud quality gate issues in commit 5c570f3:

Critical/High Severity:

• Fixed unsafe array access children[0] in serializers.ts with bounds checking
• Added type validation for all fromDict() parameters (logic, filters, op, field)

Medium Severity:

• Replaced magic numbers/strings with named constants (WILDCARD_CHAR, NEGATION_CHAR, MIN_WILDCARD_LENGTH)
• Fixed null/undefined comparison inconsistency throughout parser.ts
• Fixed private member access via string keys in builder.ts (renamed add() to public addFilter())
• Added validation for edge case where range expression has no bounds

All tests pass (53/53), linter clean, build successful.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/candoumbe/DataFilters/code-scanning/alerts
  • Triggering command: /usr/bin/gh gh api repos/candoumbe/DataFilters/code-scanning/alerts --jq .[] | select(.state == "open") | {number: .number, rule: .rule.id, file: .most_recent_instance.location.path, message: .most_recent_instance.message.text} /home/REDACTED/.nvm/bash_completion /home/REDACTED/.nvm/install.sh /home/REDACTED/.nvm/nvm-exec /home/REDACTED/.nvm/nvm.sh /home/REDACTED/.nvm/package.json /home/REDACTED/.nvm/rename_test.sh /home/REDACTED/.nvm/test conf�� get --global /home/REDACTED/work/_temp/ghcca-node/node/bin/git copilot.originalsed (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[candoumbe]

@copilot

Instead of building a typescript parser from scratch, use chevrotain to build a parser that would mimic the c# parser behavior.

At the end, parsing with typescript should give the same developer experience.
Given an input that can be a query string, the developer would call a parse method that would convert the input into a iFilter
Example :

import { parse } from parsers // <-- here the developer only import the parse method

const input = `name=*bat*,*man

const filter = parse(input) // <--- calling the parse with default options

The usage must remain the same from the caller's perspective.

The existing test should stand, especially those in parser.test.ts file which don't care about implementation details

[Copilot]

@copilot

Instead of building a typescript parser from scratch, use chevrotain to build a parser that would mimic [the c# parser](https://github.com/cand...

Done in commit 4de4007. The hand-written recursive descent parser has been replaced with a Chevrotain EmbeddedActionsParser-based implementation.

What changed in parser.ts:

• A Chevrotain Lexer with 11 tokens (Escaped, Text, TO with longer_alt to handle "TORONTO" correctly, Comma, Pipe, Bang, Asterisk, LeftSquare, RightSquare, Equals, Whitespace)
• An InternalFilterParser class extending EmbeddedActionsParser with grammar rules mirroring the C# FilterTokenParser behaviour
• The same pre-processing step (URL-decode, & → , normalisation, respecting \& escapes)
• The public API is unchanged: import { parse } from "parsers" and parse(input, options?) work exactly as before

Jest config:
Since Chevrotain is a pure-ESM package, jest.global-setup.cjs uses esbuild to pre-bundle it to CJS before tests run — keeping the existing ts-jest CommonJS setup intact.

All 77 existing tests pass (41 parser + 36 filter-class tests).

[candoumbe]

@copilot

Add missing ARRANGE, ACT, ASSERT comments so tests are easier to read

[Copilot]

Added in commit d739891. Every test in builder.test.ts now has // Arrange, // Act, and // Assert sections. The "should throw when no conditions added" test uses // Act & Assert since the assertion and the act are inseparable in a expect(() => ...).toThrow() pattern.

[sonarqubecloud]

Quality Gate failed

Failed conditions
7 Security Hotspots

See analysis details on SonarQube Cloud