fix(messages): reset terminal style after open_stream#444
Open
gcomneno wants to merge 2 commits intocanonical:mainfrom
Open
fix(messages): reset terminal style after open_stream#444gcomneno wants to merge 2 commits intocanonical:mainfrom
gcomneno wants to merge 2 commits intocanonical:mainfrom
Conversation
Contributor
Author
|
Fixed the CI regression: _safe_print and its suppress import were restored in craft_cli/printer.py. Re-ran the focused checks locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset terminal style after
open_stream()closes.If output written through
open_stream()includes ANSI control sequences that alter terminal styling, that styling could affect subsequent output because no reset sequence was emitted when the stream context manager exited.This change adds a terminal-style reset on stream close through the printer layer, and includes focused unit and integration coverage.
Testing
pytest -q tests/unit/test_messages_stream_cm.py -rs pytest -q tests/integration/test_messages_integration.py -k "third_party_output_brief_terminal or open_stream_no_text" -rs ruff check craft_cli/messages.py craft_cli/printer.py tests/unit/test_messages_stream_cm.py tests/integration/test_messages_integration.py