feat(prefixedIpInput): add prefixedInput, prefixedIpInput WD-32589 #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
omarelkashef
changed the title
omarelkashef
force-pushed
the
WD-32589-add-prefixedInput-component
branch
from
6bd7bcf to
4110fd7
Compare
omarelkashef
force-pushed
the
WD-32589-add-prefixedInput-component
branch
2 times, most recently
from
a879118 to
ad0d431
Compare
edlerd
reviewed
Jan 20, 2026
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Thanks for adding the new components. Some observations from QA below.
| @@ -0,0 +1,18 @@ | |||
| @import "vanilla-framework"; | |||
|
|
|||
| .prefixed-input { | |||
Contributor
There was a problem hiding this comment.
In Percy, there is too much spacing between the prefix and the editable part for the ip input. Though I can't reproduce it locally with Firefox and the dev server running.
omarelkashef
force-pushed
the
WD-32589-add-prefixedInput-component
branch
from
ad0d431 to
926afae
Compare
Signed-off-by: Omar Elkashef <omarelkashef01@gmail.com>
omarelkashef
force-pushed
the
WD-32589-add-prefixedInput-component
branch
from
926afae to
c16c2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-----WIP------
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps
UI should look like in LXD UI, see screenshots below
