feat: added custom dars example by PHOL-DA · Pull Request #1607 · canton-network/wallet

PHOL-DA · 2026-04-13T11:42:12Z

anything in the damljs/ is codegen, so i leave it up to the reviewer if they want to go through those 600+ files.

recommended to reivew:
script 14, showcasing custom dar implementation
Typed contracts
implementation guide

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

mjuchli-da

The focus of this PR lays imho on typed-contract.ts, which is a (de-)serialization facility from/to codegen objects.

This has been clunky for a while in the current codegen and there is an ongoing (scala) project that is supposed to introduce an improved codegen that covers the features here (will remember the name of the project tomorrow hopefully).

That said, we have done similar things in Java in the past where one could use the COMPANION object (belonging to a codegenned template): https://github.com/mjuchli-da/pqsj/blob/main/src/main/java/com/daml/pqsj/repository/ContractRepository.java#L44. Maybe there is similar stuff for Typescript given?

As for the rest: this resembles a classical App that makes use of some arbitrary daml codegen (and daml generic types) – the same way it has been done since Daml 2.0. As such, any reference to dvp should imho reside as an independent example app under /examples/dvp (or similar). This includes all the boilerplating necessary to build this app; except of course the codegen itself which must be built as part of the example app build.

(Extremely hard to review, highlights that codegen does not belong in a repo).

mjuchli-da · 2026-04-13T23:20:43Z

 // SPDX-License-Identifier: Apache-2.0

 export { AcsReader, AcsOptions } from './acs-reader.js'
+export {


mjuchli-da · 2026-04-13T23:20:50Z

+// Copyright (c) 2025-2026 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+export type AcsContractLike = {


mjuchli-da · 2026-04-13T23:23:53Z

@@ -30,6 +30,7 @@
        "script:generate:protobufs": "tsx ./scripts/src/generate-protobufs.ts",
        "script:generate:tokenstandard": "tsx ./scripts/src/generate-token-standard.ts",
        "script:generate:featured-dars": "tsx ./scripts/src/generate-featured-dars.ts",
+        "script:generate:dvp-testing-app": "tsx ./scripts/src/generate-dvp-testing-app.ts",


Command specific so an example app

so the dvp trading is not an example app, we use it several places in code (script 04 and otc-trade.ts specifically in our repo).

so any place where we test transfer allocations, then we need the dvp trading app

mjuchli-da · 2026-04-13T23:23:55Z

@@ -53,7 +54,11 @@
        "api-specs",
        "core/**",
        "docs/wallet-integration-guide/examples",
-        "damljs/**",
+        "damljs/token-standard-models/**",


Also an app under /examples can depend on some 3rd party package – either internally generated or from an external source

mjuchli-da · 2026-04-13T23:28:03Z

@@ -122,7 +127,31 @@
        "glob": "^10.5.0",
        "vite": "^7.2.4",
        "uri-js": "npm:uri-js-replace@^1.0.1",
-        "seroval": "^1.4.2"
+        "seroval": "^1.4.2",
+        "@daml.js/daml-prim-DA-Exception-ArithmeticError-1.0.0": "workspace:^",


This is a classical setup (standard practice since Daml 2.0), where a frontend app (dvp example in this case) depends on 1) generic daml types and 2) dar specific codegen. As such, we shouldn't have any of these dependencies in our root package.json

this is not dependencies but resolutions, im just telling the repo (now that it is finding multiple versions) which version to use

mjuchli-da · 2026-04-13T23:36:06Z

@@ -30,6 +30,7 @@
        "script:generate:protobufs": "tsx ./scripts/src/generate-protobufs.ts",
        "script:generate:tokenstandard": "tsx ./scripts/src/generate-token-standard.ts",
        "script:generate:featured-dars": "tsx ./scripts/src/generate-featured-dars.ts",
+        "script:generate:dvp-testing-app": "tsx ./scripts/src/generate-dvp-testing-app.ts",


Move to example app

mjuchli-da · 2026-04-13T23:36:22Z

@@ -53,7 +54,11 @@
        "api-specs",
        "core/**",
        "docs/wallet-integration-guide/examples",
-        "damljs/**",
+        "damljs/token-standard-models/**",


Codegen should not be part of the repo

codegen is already part of the repo, we do it for the token standard. All i did was make it work with more than one codegen from daml in the repo

this was actually to avoid to many of the codegen packages being part of our repo (now we only have the four main packages instead of every single codegen package)

mjuchli-da · 2026-04-13T23:36:48Z

+
+    .. code-block:: typescript
+
+        const proposalsForBob = toTemplateContracts<


I would try to hide this in sdk.ledger.acs.read(args, TradingApp.COMPANION)

mjuchli-da · 2026-04-13T23:40:26Z

+    return contract as TypedAcsContract<TPayload, TContract>
+}
+
+export function toTemplateContracts<


In the java codegen there are COMPANION objects for each template, isn't this the case in typescript?
If so, they come with a parse function.

no companion object here (this is the TS file for dvp trading app):
https://github.com/hyperledger-labs/splice-wallet-kernel/pull/1607/changes#diff-9bff8d85136cfa7acd2689527cd10e0daef5ec18d9431c1aaf973ae8f190ff71

mjuchli-da · 2026-04-13T23:41:18Z

+    return contract as TypedAcsContract<TPayload, TContract>
+}
+
+export function toTemplateContracts<


In the java codegen there are COMPANION objects for each template, isn't this the case in typescript?
If so, they come with a parse function.

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

PHOL-DA added 3 commits April 13, 2026 12:36

fix codegen to support multiple different packages

8e8ab07

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

custom dars script

d5cd02b

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

added documentation

91420ee

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

PHOL-DA requested review from a team as code owners April 13, 2026 11:42

Merge branch 'main' into phol/daml-codegen

a54ff19

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

github-advanced-security AI found potential problems Apr 13, 2026

View reviewed changes

Comment thread scripts/src/lib/utils.ts Dismissed

PHOL-DA added 4 commits April 13, 2026 14:21

.nxignore

98c6970

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

minor fix

dd731c2

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

package resolution

156beef

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

fix example 14

bdad5d4

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

mjuchli-da requested changes Apr 13, 2026

View reviewed changes

PHOL-DA added 2 commits April 14, 2026 08:05

Merge branch 'main' into phol/daml-codegen

ddb42d3

fix build

961a70a

Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>

This was referenced Apr 17, 2026

feat(core-daml-codegen-helpers): created new helper classes #1639

Merged

chore: updated daml codegen script #1642

Closed


		.. code-block:: typescript

		const proposalsForBob = toTemplateContracts<

Conversation

PHOL-DA commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mjuchli-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PHOL-DA commented Apr 13, 2026 •

edited

Loading