feat(wallet-sdk,core-acs-reader): add caching to acs reader#1650
Open
mateuszpiatkowski-da wants to merge 17 commits into
Open
feat(wallet-sdk,core-acs-reader): add caching to acs reader#1650mateuszpiatkowski-da wants to merge 17 commits into
mateuszpiatkowski-da wants to merge 17 commits into
Conversation
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
PHOL-DA
approved these changes
Apr 29, 2026
Contributor
PHOL-DA
left a comment
PHOL-DA
left a comment
There was a problem hiding this comment.
LGTM, would love to see some tests to verify it works 😄
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Contributor
Author
@PHOL-DA thx :) As for the tests: did you mean something else than https://github.com/hyperledger-labs/splice-wallet-kernel/pull/1650/changes#diff-2ee7e591adb0144ab65f486142a3a38609bbe819ddaf25ea0e63c3c88ea372b3? |
PHOL-DA
previously approved these changes
May 4, 2026
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
mateuszpiatkowski-da
changed the title
mateuszpiatkowski-da
changed the title
PHOL-DA
requested changes
May 15, 2026
| "dependencies": { | ||
| "@canton-network/core-ledger-client-types": "workspace:^", | ||
| "@canton-network/core-provider-ledger": "workspace:^", | ||
| "@canton-network/core-token-standard": "workspace:^", |
Contributor
There was a problem hiding this comment.
why does the acs reader need token standard ?
| // Copyright (c) 2025-2026 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { ContractId } from '@canton-network/core-token-standard' |
Contributor
There was a problem hiding this comment.
ContractId should be a primitive further down that token standard, so we should probably move that (a ContractId is not unique to token standard, but rather a primitive type for all daml contracts)
| } from '@canton-network/core-ledger-client-types' | ||
| import { Logger, PartyId } from '@canton-network/core-types' | ||
| import { AcsReader, AcsOptions } from '@canton-network/core-acs-reader' | ||
| import { ACSReader, AcsOptions } from '@canton-network/core-acs-reader' |
Contributor
There was a problem hiding this comment.
because you import token standard into the acs reader, you effectively have a circular dependency here
| ) | ||
| } | ||
|
|
||
| acs = { |
Contributor
There was a problem hiding this comment.
we don't have the liberty anymore to just remove stuff, we should mark with @deprecated where applicable
| ] | ||
| ], | ||
| "analytics": false, | ||
| "nxCloudId": "6a05b93522efcb8f608e1a3d" |
Contributor
There was a problem hiding this comment.
this is probably why the static test was failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.