chore: remove damljs as workspaces#1684
Merged
Merged
Conversation
Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>
Signed-off-by: Phillip Olesen <phillip.olesen@digitalasset.com>
pawelstepien-da
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What came first damljs/token-standard-model or yarn script:generate:tokenstandard?
-Phillip Olesen
the above frames the problem perfectly, currently yarn install (which is needed before yarn script:generate:tokenstandard) is dependent on the exact output that it generates. This PR changes that behavior using rollup so that the damljs/token-standard-model can stop being a dependency for yarn install.
this is first or a series of PR that encapsulates partial functionality of #1642.
with these changes we should have a clear sequence of commands like:
yarn install
yarn generate...
yarn build:all
follow up PR will remove the damljs/token-standard-model generated files from the repo and instead have the generate runs on each PR.