Removed default synchronizer #1740
Draft
jarekr-da wants to merge 11 commits into
Draft
Conversation
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…licitly - Remove SDKContext.defaultSynchronizerId / globalSynchronizerId and the associated startup API call (GET /v2/state/connected-synchronizers) - LedgerClient.getSynchronizerId() now prefers the synchronizer aliased 'global' over the arbitrary first entry (still used by wallet-gateway) - internal.submit() and internal.prepare() omit synchronizerId when not given so canton routes by the contracts involved (ledger-api default) - Callers that wrap ledger-API calls pass synchronizerId through as-is using conditional spread to satisfy exactOptionalPropertyTypes - Amulet operations that embed synchronizerId in DAML choice args or disclosed contracts (traffic.buy/status, featuredApp.grant, preapproval.renew, external party allocation) throw a clear error when the caller does not supply it — canton cannot choose it for those Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
- Delete getSynchronizerId() from LedgerClient — auto-selecting a synchronizer is no longer the SDK's responsibility - wallet-gateway callers now use network.synchronizerId / this.synchronizerId directly; throw with a clear message when not configured - Internal party allocation uses conditional spread so synchronizerId is absent from the POST /v2/parties body when not set (exactOptionalPropertyTypes) Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…y.external.create() Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…) and sub-scripts Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
changed the title
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
… internally The SDK now decides everything with regard to synchronizers. - Remove State.globalSynchronizerId() from the public API - Add internal resolveGlobalSynchronizerId(ledgerProvider) helper used by SDK operations that need the global synchronizer (traffic, preapproval, featuredApp.grant, party.external.create/allocate, mergeDelegation) - Remove findGlobalSynchronizer() from ExternalPartyNamespace (duplicate logic) - Remove synchronizerId param from TrafficNamespace.status/buy, PreapprovalNamespace.renew, GrantFeaturedAppRightsOptions, and MergeDelegationNamespace.setup/approve/execute - Drop getGlobalSynchronizerId() helper from example utils/index.ts - Update all example scripts to stop passing synchronizerId to SDK calls - 15-multi-sync/_setup.ts retains explicit synchronizer lookup (appropriate: it is test setup that needs both global + app IDs by alias) Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.