Skip to content

feat: surface structured rejection fields from gRPC response (RFC-008 B8) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beonde merged 2 commits into from
May 6, 2026
Merged

feat: surface structured rejection fields from gRPC response (RFC-008 B8) #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e7577e
feat: surface structured rejection fields from gRPC response (RFC-008…
beonde May 6, 2026
f586b58
fix: address Copilot review feedback on RFC-008 B8
beonde May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions capiscio_sdk/_rpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,6 +1607,7 @@ def evaluate_tool_access(
mcp_pb2.MCP_DENY_REASON_TOOL_NOT_ALLOWED: "tool_not_allowed",
mcp_pb2.MCP_DENY_REASON_ISSUER_UNTRUSTED: "issuer_untrusted",
mcp_pb2.MCP_DENY_REASON_POLICY_DENIED: "policy_denied",
mcp_pb2.MCP_DENY_REASON_SCOPE_INSUFFICIENT: "scope_insufficient",
}

auth_level_map = {
Expand Down Expand Up @@ -1636,6 +1637,10 @@ def evaluate_tool_access(
"evidence_json": response.evidence_json,
"evidence_id": response.evidence_id,
"timestamp": timestamp_str,
"error_code": response.error_code,
"rejection_detail": response.rejection_detail,
"requested_capability": response.requested_capability,
"presented_capability": response.presented_capability,
Comment on lines +1640 to +1643

@beonde beonde May 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f586b58 — added tests/unit/test_mcp_structured_fields.py with 3 tests covering: deny response with structured fields, allow response with empty fields, and presence of all expected keys.

}
Comment on lines 1639 to 1644

@beonde beonde May 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f586b58 — rejection_detail is now included in the return dict.


def verify_server_identity(
Expand Down
Loading
Loading