Fix working dir bug when composer:run is executed directly via the CLI #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not running via a deploy (e.g. composer:run executed directly via CLI), the command fails because the release_path variable is not set. It's only set as part of a deploy. This fix changes the way composer:run works: when not executed within the context of a deploy, Composer's working directory will be set to current_path instead of release_path. This is a backwards-compatible bugfix, but it might be worth bumping at least minor version because behavior changes considerably for end-users.
gsomoza
force-pushed
the
fix-release-path-on-run
branch
from
306534d to
e0b0ff2
Compare
Author
|
Ping :) |
|
Same issue here. After this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not running via a deploy (e.g. composer:run executed directly via CLI), the command fails because
the release_path variable is not set. It's only set as part of a deploy.
This fix changes the way composer:run works: when not executed within the context of a deploy, Composer's
working directory will be set to current_path instead of release_path.
This is a backwards-compatible bugfix, but it might be worth bumping at least minor version because
behavior changes considerably for end-users.