fix: Add comma formatting to size display values#123
Open
onchito-walks wants to merge 1 commit into
Open
Conversation
- Added addCommas() helper for formatting numbers with comma separators - Updated formatForDisplay() to use addCommas() for all return paths - Fixed 'Size to close is not well formatted' bug for amounts >= 1000 or with decimal places - Large position sizes now display as 5,000.00 instead of just 5000 Bounty: capofficial#11 Payment: 1Ast5dKr9z1bLWFBnyh6WDQSgyL7EHJosp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation
Fixed the "Size to close is not well formatted, sometimes" bug by adding proper comma formatting to all display paths in formatForDisplay().
Changes
Before
After
Payment
BTC: 1Ast5dKr9z1bLWFBnyh6WDQSgyL7EHJosp