Remove unnecessary to_i calls in Record#+ for last_executed_at#3
Merged
tonytonyjan merged 1 commit intoMar 12, 2026
Conversation
The last_executed_at values are already integers (from Time.now.to_i in the recorder and JSON-parsed integers from the store), so the to_i conversion is redundant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I reviewed d7e911d and noticed this potentially unnecessary
to_i.Unless I'm missing something, the
last_executed_atvalues are already integers because ofTime.now.to_i.Test Plan
test_sum already covers this.