Added grid view and advanced search dialog#95
Draft
xgrommx wants to merge 1 commit intocardisoft:masterfrom
Draft
Added grid view and advanced search dialog#95xgrommx wants to merge 1 commit intocardisoft:masterfrom
xgrommx wants to merge 1 commit intocardisoft:masterfrom
Conversation
xgrommx
force-pushed
the
grid-view-and-advanced-search-builder
branch
from
3b42479 to
8322b4b
Compare
Collaborator
|
Wow, thanks for this great change! Trying it now. |
Collaborator
|
@xgrommx Sorry for the long delay, I am busy with my work recently. Great addition and thanks for your effort! I love the query builder(I never wished this could be implemented like this) and the grid view. The UI is impressive. Could you split them into two separate PRs or two PRs like: (the query builder) & (the query builder + grid view) since they are logically separated? Currently the app crashes when I scrolls to the end of the grid view. I am going to investigate on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @ldm0, can u check my draft? I just added some ideas