fix: Make exception params nullable and update test#26
Open
skybluesofa wants to merge 2 commits intodevelopmentfrom
Open
fix: Make exception params nullable and update test#26skybluesofa wants to merge 2 commits intodevelopmentfrom
skybluesofa wants to merge 2 commits intodevelopmentfrom
Conversation
Allow nullable types for several exception constructors and update a test helper signature. Changes: - NotFoundException: make $message nullable (?string) and allow nullable $previous. - RemoteAuthentication: make $message nullable (?string). - UpstreamException: import Throwable and make $previous nullable (?Throwable). - MocksGuzzleInstance: allow $count to be nullable (?int) in assertTapperRequestLike. These changes prevent strict type errors when null values are passed and align signatures across exceptions and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow nullable types for several exception constructors and update a test helper signature.
Changes:
These changes prevent strict type errors when null values are passed and align signatures across exceptions and tests.