Skip to content

ci: require canonical npm token for publishing #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbusillo merged 1 commit into from
May 24, 2026
Merged

ci: require canonical npm token for publishing #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,12 @@ jobs:
- name: Validate npm authentication (must fail fast if missing/invalid)
run: |
set -euo pipefail
publish_token="${NPM_TOKEN:-${NODE_AUTH_TOKEN:-}}"
if [ -z "$publish_token" ]; then
if [ -z "${NPM_TOKEN:-}" ]; then
echo "::warning::NPM_TOKEN is missing; skipping npm publish for this GitHub-release-only run." >&2
exit 0
fi

echo "//registry.npmjs.org/:_authToken=${publish_token}" > ~/.npmrc
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc

if npm whoami >/dev/null 2>&1; then
echo "npm auth ok"
Expand Down Expand Up @@ -964,7 +963,7 @@ jobs:
id: should_publish
shell: bash
run: |
if [ -z "${NPM_TOKEN:-${NODE_AUTH_TOKEN:-}}" ]; then
if [ -z "${NPM_TOKEN:-}" ]; then
echo "publish=false" >> "$GITHUB_OUTPUT"
else
echo "publish=true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -1081,14 +1080,13 @@ jobs:
shell: bash
run: |
set -euo pipefail
publish_token="${NPM_TOKEN:-${NODE_AUTH_TOKEN:-}}"
if [ -z "$publish_token" ]; then
if [ -z "${NPM_TOKEN:-}" ]; then
echo "npm auth token missing; cannot publish binary packages" >&2
exit 1
fi
config_path="${NPM_CONFIG_USERCONFIG:-$HOME/.npmrc}"
mkdir -p "$(dirname "$config_path")"
echo "//registry.npmjs.org/:_authToken=${publish_token}" > "$config_path"
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > "$config_path"
npm whoami >/dev/null 2>&1 || { echo "npm auth failed (npm whoami). Ensure NPM_TOKEN is a granular/automation token with publish rights to @just-every/* and bypass 2FA enabled; update the secret via npmjs.com." >&2; exit 1; }
shopt -s nullglob
for dir in npm-binaries/*; do
Expand All @@ -1110,14 +1108,13 @@ jobs:
shell: bash
run: |
set -euo pipefail
publish_token="${NPM_TOKEN:-${NODE_AUTH_TOKEN:-}}"
if [ -z "$publish_token" ]; then
if [ -z "${NPM_TOKEN:-}" ]; then
echo "npm auth token missing; cannot publish main package" >&2
exit 1
fi
config_path="${NPM_CONFIG_USERCONFIG:-$HOME/.npmrc}"
mkdir -p "$(dirname "$config_path")"
echo "//registry.npmjs.org/:_authToken=${publish_token}" > "$config_path"
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > "$config_path"
npm whoami >/dev/null 2>&1 || { echo "npm auth failed (npm whoami). Ensure NPM_TOKEN is a granular/automation token with publish rights to @just-every/* and bypass 2FA enabled; update the secret via npmjs.com." >&2; exit 1; }
name="@just-every/code"
version=$(jq -r '.version' package.json)
Expand Down