#53 implement thumbnail limit settings#54
Open
TreehouseFalcon wants to merge 3 commits into
Open
Conversation
TreehouseFalcon
force-pushed
the
fix/limit-setting
branch
from
c94fe11 to
2c974fb
Compare
TreehouseFalcon
force-pushed
the
fix/limit-setting
branch
from
2c974fb to
43bfbf4
Compare
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to solve
Resolves #53
Thumbnail limit settings are not implemented
Limit set to 95:
(in theory, crashes game in practice)
Solution
Implement the limit in
LevelCell.cppbased on cell index.Tested on Geode via Crossover on macOS Tahoe
Limit set to 95:
(no notable performance hit)