cli-17: Fix special character escaping in tool descriptions#512
Merged
dwash96 merged 6 commits intoMay 13, 2026
Merged
Conversation
added 5 commits
April 29, 2026 19:24
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
…7-fix-special-character-escaping
dwash96
pushed a commit
that referenced
this pull request
May 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes special character escaping issues in tool descriptions across multiple files:
Changes
The changes primarily focus on:
models.py: Added JSON escaping for tool descriptions to handle special characters like quotes, backslashes, and newlines properly. This prevents JSON parsing errors when these descriptions are passed to LLM APIs.
agent_coder.py, io.py, context_manager.py, read_range.py: Fixed inconsistent line breaks and spacing in multi-line strings to improve readability and maintain consistency.
tests/basic/test_models.py: Added a test case to verify that tool descriptions with special characters are properly escaped before being sent to the LLM API.
Why This Matters
These changes ensure that:
The test case verifies that the escaping mechanism works correctly with complex strings containing various special characters.
Testing
The changes have been tested with the new test case in test_models.py that verifies the escaping of special characters in tool descriptions.
Fixes: cli-17