feat: add google cloud kms support to rebalancer#36
Draft
damiannolan wants to merge 3 commits intomainfrom
Draft
feat: add google cloud kms support to rebalancer#36damiannolan wants to merge 3 commits intomainfrom
damiannolan wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
It is pointless to add gcloud kms support to rebalancer service here unless we also add it to the solver. Since the point of the rebalancer is to manage solver inventory. When using a secp256k1 ECDSA key with gcloud, it is cloud HSM backed, and the user cannot actually export the raw private key material from gcloud. Therefore, the solver service itself must also support tx signing with gcloud kms in order to use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adding gcloud kms support for rebalancer.