simplify the missing_event test to not spin on the node itself#1
Open
wjwwood wants to merge 1 commit intocellumation:missing_eventfrom
Open
simplify the missing_event test to not spin on the node itself#1wjwwood wants to merge 1 commit intocellumation:missing_eventfrom
wjwwood wants to merge 1 commit intocellumation:missing_eventfrom
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
This was referenced Nov 30, 2023
jmachowinski
force-pushed
the
missing_event
branch
2 times, most recently
from
fdb656d to
3ceaa9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the title, it removes the need to spin on the node and wait for an unknown number of things the test doesn't care about to be spun on.