Chore: Add the clientname option for fio and librbdfio#335
Open
rfakit wants to merge 6 commits intoceph:masterfrom
Open
Chore: Add the clientname option for fio and librbdfio#335rfakit wants to merge 6 commits intoceph:masterfrom
rfakit wants to merge 6 commits intoceph:masterfrom
Conversation
added 6 commits
May 30, 2025 18:56
…it | make it more verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clientname option for fio and librbdfio benchmarks
Description
This PR adds a configurable
clientnameoption to both thefioandlibrbdfiobenchmark classes in CBT. This enhancement allows users to specify a custom client name when running FIO benchmarks against RBD endpoints, rather than being limited to the hardcoded 'admin' client name.Changes
clientnameconfiguration option toFioclass with a default value of 'admin'clientnameconfiguration option toLibrbdFioclass with a default value of 'admin'LibrbdFioto use the configured clientnameTesting
The changes have been tested with:
Usage Example
Impact
This change is backward compatible as it maintains the default 'admin' clientname if not specified in the configuration. Users who don't specify a clientname will see no change in behavior.
Related Issues
N/A
Checklist